[travis-ci] Zend Garbage Collection only for PHP5.4 #6063
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,10 @@ | |||
| <?php | |||
|
|
|||
| if (version_compare(PHP_VERSION, '5.4', '>=') && gc_enabled()) { | |||
| // Disabling Zend Garbage Collection to prevent segfaults with PHP5.4+ | |||
There was a problem hiding this comment.
Can you add the reference to the relevant PHP bugs, so that we can remove this when it is fixed upstream? Thanks.
There was a problem hiding this comment.
Also, I'm not sure this is the right thing to do as for instance I have no problem running the test locally with PHP 5.4. Is it related to Travis somehow?
There was a problem hiding this comment.
@fabpot but is gc enabled locally ?
There was a problem hiding this comment.
@fabpot had the same problem on multiple ubuntu vps already
There was a problem hiding this comment.
fair enough. Can you add the references to the PHP bugs before I merge?
|
I think this should have been merged into 2.0 to avoid travis failures in the tetssuite for these branches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.