Improve typing for process callback #60679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
309ed89 to
00cce47
Compare
01f0536 to
71469bc
Compare
src/Symfony/Component/Console/Command/DumpCompletionCommand.php
Outdated
Show resolved
Hide resolved
stof
requested changes
Jun 4, 2025
449f89c to
64c9f21
Compare
|
All comments should be addressed. Thanks for the reviews. |
a4fa6be to
56cc4ff
Compare
jack-worman
commented
Jun 4, 2025
56cc4ff to
4f6aa8f
Compare
4f6aa8f to
d8dc857
Compare
|
Thank you @jack-worman. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always find myself digging into the source code to determine what the "shape" of the callback should be. This improvement allows static analysis tools to ensure its correct now.