Improve-callable-typing #60762
Merged
Improve-callable-typing #60762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
609c5fd to
eeb6152
Compare
jack-worman
commented
Jun 11, 2025
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
stof
requested changes
Jun 11, 2025
Contributor
Author
|
Thanks for the review. |
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
LGTM except for the changes in FrameworkBundle's DependencyInjection namespace which look useless to me.
435e0be to
fb3c39c
Compare
Contributor
Author
I reverted those changes. But I would like to say: static analysis tools are only as useful as the typing you give them! |
Member
|
Thank you @jack-worman. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining a callable's shape is important to have valid static analysis.
It also improves documentation because developers no longer need to search the source code for what callable shape to use.