[Serializer] improve phpdoc for normalizer #60769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also apply the improvement in DenormalizerInterface please ? SerializerInterface already has the precise type. |
0e1c487 to
e26ff94
Compare
|
Thank you @garak. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with the old phpdoc is that phpstan complains about the user's concrete implementation ("no value type specified in iterable type array")
Moreover, if the user adds the proper phpdoc in their concrete implementation, phpstan still complains about the concrete method not being contravariant (using strict rules)
After a Slack discussion with @stof we agreed that this small improvement could be useful, and avoid being forced to install phpstan-symfony to get the proper annotation.