[JsonPath] Handle slice selector overflow #60798
Open
+74
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82834d9 to
b9231c9
Compare
b9231c9 to
4791ff8
Compare
xabbuh
reviewed
Jun 16, 2025
| $start = '' !== $matches[1] ? (int) $matches[1] : null; | ||
| $end = '' !== $matches[2] ? (int) $matches[2] : null; | ||
| $step = isset($matches[3]) && '' !== $matches[3] ? (int) $matches[3] : 1; | ||
| $start = '' !== $startStr ? (int) $startStr : null; |
There was a problem hiding this comment.
How does this work if $startStr is the representation of an integer that exceeds PHP_INT_MAX? Or is lower than PHP_INT_MINX?
There was a problem hiding this comment.
It will be caught by the call to JsonPathUtils::isIntegerOverflow() above: safe JSON integer interval is narrower compared to PHP integer interval. It may be different on 32 bits systems though. I don't know how common it is these days to add a check for it? It would imply more complexity as we would compare numbers as strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slice selector integers must always be in the interval [-(2^53) + 1, (2^53) - 1], and leading 0 are forbidden.