Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[JsonPath] Improve escape sequence validation in name selector #60802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 7.3
Choose a base branch
from
Open

[JsonPath] Improve escape sequence validation in name selector #60802

wants to merge 1 commit into from

Conversation

alexandre-daubois
Copy link
Member

Q A
Branch? 7.3
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

@carsonbot carsonbot added this to the 7.3 milestone Jun 16, 2025
stof
stof reviewed Jun 16, 2025
View reviewed changes
src/Symfony/Component/JsonPath/JsonPathUtils.php Outdated
'b' => "\b",
'f' => "\f",
'b' => "\x08",
'f' => "\x0C",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why changing those ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\f is a mistake, but \b is actually not recognized by PHP, thus using the hex value directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

Assignees
No one assigned
Labels
Bug JsonPath Status: Needs Review
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandre-daubois @stof @carsonbot