[Validator] Add min and max in both error messages of LengthValidator
#60805
+45
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d18fd05 to
6182584
Compare
min and max in both error messages of LengthValidator
6182584 to
4a539fb
Compare
|
The Tests on 8.2 high-deps are failing because this PR How do I solve this ? |
OskarStark
reviewed
Jun 16, 2025
a521b0f to
f51245e
Compare
|
Friendly ping @nicolas-grekas you might know how to solve the failure #60805 (comment) Test are failing but I feel like I cannot fix them since it runs the 6.4 version and I'm on the 7.4 branch... |
f51245e to
8df3197
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow to use the same message for a Length constraint which say
"The length needs to be between {{ min }} and {{ max }}".