[HttpFoundation] Handle error when expected directory is a file #60808
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
This comment was marked as outdated.
This comment was marked as outdated.
3337a3a to
c1c4494
Compare
In File::getTargetFile the directory is recursively created if it does not exists. If directory creation fails a FileException is thrown. This commit improves error clarity by adding a new Exception for the relatively common situation where the path exists but instead of a directory it is a file.
c1c4494 to
3d65354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[HttpFoundation] In File::getTargetFile the directory is recursively created if it does not exists. If directory creation fails a FileException is thrown.
This commit improves error clarity by adding a new FileException for the relatively common case where the path exists but instead of a directory it is a file.
Since errors from @mkdir are being suppressed we don't really know why the operation has failed.
There are many ways of doing this depending on the warranties that Symfony gives on retro-compatibility for the thrown exceptions. I Haven't been able to find documentation about that so I've decided to open a PR with the easiest to read change to get the conversation started.
Depending on your preferences we could:
Also since I haven't been able to find the compatibility guidelines I'm doing this to the 7.4 branch.