Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Dotenv] Remove DebugCommand::$defaultName and $defaultDescription #60847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

[Dotenv] Remove DebugCommand::$defaultName and $defaultDescription #60847

merged 1 commit into from
Jun 20, 2025
+5 −25

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Jun 20, 2025 •
edited
Loading

Q A
Branch? 8.0
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

The command is configured by the #[AsCommand] attribute. The public static properties were kept for only for backward compatibility.

No upgrade instruction needed.

@GromNaN GromNaN requested review from xabbuh and yceruto as code owners June 20, 2025 09:31
@carsonbot carsonbot added this to the 8.0 milestone Jun 20, 2025
chalasr
chalasr approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPGRADE-8.0 should probably be updated as well since this is a BC break. No, the class if final

@fabpot
Copy link
Member

fabpot commented Jun 20, 2025

Thank you @GromNaN.

@fabpot fabpot merged commit faed8e8 into symfony:8.0 Jun 20, 2025
6 of 9 checks passed
@GromNaN GromNaN deleted the dotenv-command branch June 20, 2025 10:42
GromNaN
GromNaN commented Jun 20, 2025
View reviewed changes
src/Symfony/Component/Form/CHANGELOG.md
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I edited the wrong changelog. Thanks @fabpot for the fix 478f5c3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@yceruto yceruto yceruto approved these changes

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

@chalasr chalasr chalasr approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Dotenv Feature Status: Reviewed
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
7 participants
@GromNaN @fabpot @OskarStark @yceruto @alexandre-daubois @chalasr @carsonbot