[Serializer] Remove deprecated withDefaultContructorArguments method #60865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mttsch
commented
Jun 21, 2025
| Q | A |
|---|---|
| Branch? | 8.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
xabbuh
reviewed
Jun 21, 2025
UPGRADE-8.0.md
Outdated
| Serializer | ||
| ---------- | ||
|
|
||
| * Remove `AbstractNormalizerContextBuilder::withDefaultContructorArguments(?array $defaultContructorArguments)`, use `withDefaultConstructorArguments(?array $defaultConstructorArguments)` instead |
There was a problem hiding this comment.
Suggested change
| * Remove `AbstractNormalizerContextBuilder::withDefaultContructorArguments(?array $defaultContructorArguments)`, use `withDefaultConstructorArguments(?array $defaultConstructorArguments)` instead | |
| * Remove `AbstractNormalizerContextBuilder::withDefaultContructorArguments()`, use `withDefaultConstructorArguments()` instead |
There was a problem hiding this comment.
Done. I used the same structure as for the 7.1 changelog, where parameter names are also present, but that was inconsistent with the rest.
0919384 to
b5d8ecb
Compare
xabbuh
approved these changes
Jun 21, 2025
OskarStark
requested changes
Jun 21, 2025
UPGRADE-8.0.md
Outdated
| Serializer | ||
| ---------- | ||
|
|
||
| * Remove `AbstractNormalizerContextBuilder::withDefaultContructorArguments()`, use `withDefaultConstructorArguments()` instead |
There was a problem hiding this comment.
Suggested change
| * Remove `AbstractNormalizerContextBuilder::withDefaultContructorArguments()`, use `withDefaultConstructorArguments()` instead | |
| * Remove `AbstractNormalizerContextBuilder::withDefaultContructorArguments()`, use `withDefaultConstructorArguments()` instead |
| 8.0 | ||
| --- | ||
|
|
||
| * Remove `AbstractNormalizerContextBuilder::withDefaultContructorArguments()`, use `withDefaultConstructorArguments()` instead |
There was a problem hiding this comment.
Suggested change
| * Remove `AbstractNormalizerContextBuilder::withDefaultContructorArguments()`, use `withDefaultConstructorArguments()` instead | |
| * Remove `AbstractNormalizerContextBuilder::withDefaultContructorArguments()`, use `withDefaultConstructorArguments()` instead |
b5d8ecb to
de5f7d3
Compare
OskarStark
approved these changes
Jun 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.