[WebProfilerBundle] Fix missing indent on non php files opended in the profiler #60867
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
The CI failures look related. |
5eb2fec to
5aa9f2f
Compare
| @@ -241,7 +287,7 @@ protected static function fixCodeMarkup(string $line): string | |||
| // missing </span> tag at the end of line | |||
| $opening = strpos($line, '<span'); | |||
| $closing = strpos($line, '</span>'); | |||
| if (false !== $opening && (false === $closing || $closing > $opening)) { | |||
| if (false !== $opening && (false === $closing || $closing < $opening)) { | |||
There was a problem hiding this comment.
note: there was a double </span> at the end of the line ; maybe the logic was broken, it added a </span> at the end of the line when an opening span was found and the opening span was before the closing span which seems perfectly fine.
0dec8d1 to
08bd097
Compare
08bd097 to
2951d06
Compare
This fixes non-php files indent in profiler.
Testing
Considering any project running at https://127.0.0.1:8000
Non-php file: https://127.0.0.1:8000/_profiler/open?file=config/packages/framework.yaml&line=0
PHP file: https://127.0.0.1:8000/_profiler/open?file=src/Kernel.php&line=0