[Console] Make $input argument for CommandTester optional
#60873
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why require an input to be passed when none is needed?
OskarStark
approved these changes
Jun 23, 2025
|
But that's a BC break 😬 |
|
😢 So this cannot be done then? |
|
We'd need to make the class final, but that could only be done if there are alternatives to inheritance, which I'm not sure of. Then it could be done only in Symfony 8. But that might be a bit too heavy for the community, just to save two chars... |
|
Ok, thanks for the explanation. Let's close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why require an input to be passed when none is needed?
It would look better if I could do: