[Console] Fix command option mode (InputOption::VALUE_REQUIRED) #60914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34d24df to
dde6dfa
Compare
welcoMattic
reviewed
Jun 27, 2025
| new InputOption('sort', null, InputOption::VALUE_OPTIONAL, 'Return list of messages sorted alphabetically (only works with --dump-messages)', 'asc'), | ||
| new InputOption('as-tree', null, InputOption::VALUE_OPTIONAL, 'Dump the messages as a tree-like structure: The given value defines the level where to switch to inline YAML'), | ||
| new InputOption('as-tree', null, InputOption::VALUE_REQUIRED, 'Dump the messages as a tree-like structure: The given value defines the level where to switch to inline YAML'), |
There was a problem hiding this comment.
This one is an on/off, no value is expected here.
There was a problem hiding this comment.
The description says The given value defines the level where to switch to inline YAML..
And the help text of the command contains this:
<info>php %command.full_name% --force --format=yaml --as-tree=3 en AcmeBundle</info>
| new InputOption('domains', null, InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY, 'Specify the domains to pull.'), | ||
| new InputOption('locales', null, InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY, 'Specify the locales to pull.'), | ||
| new InputOption('format', null, InputOption::VALUE_REQUIRED, 'Override the default output format.', 'xlf12'), | ||
| new InputOption('as-tree', null, InputOption::VALUE_REQUIRED, 'Write messages as a tree-like structure. Needs --format=yaml. The given value defines the level where to switch to inline YAML'), |
There was a problem hiding this comment.
Boolean option too, no value expected.
stof
approved these changes
Jun 27, 2025
|
Thank you @gharlan. |
This was referenced Jun 28, 2025
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think in all given cases it was a mistake to use
InputOption::VALUE_OPTIONALinstead ofInputOption::VALUE_REQUIRED.It is a common mistake to think that you have to use
VALUE_OPTIONALto make the option optional. But options are always optional. 😉