Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Console] Fix TreeHelper::addChild when providing a string #61080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2025
Merged

[Console] Fix TreeHelper::addChild when providing a string #61080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Console/Helper/TreeNode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public function getValue(): string
public function addChild(self|string|callable $node): self
{
if (\is_string($node)) {
$node = new self($node, $this);
$node = new self($node);
}

$this->children[] = $node;
Expand Down
20 changes: 20 additions & 0 deletions src/Symfony/Component/Console/Tests/Helper/TreeHelperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,26 @@ public function testRenderNodeWithMultipleChildren()
TREE, self::normalizeLineBreaks(trim($output->fetch())));
}

public function testRenderNodeWithMultipleChildrenWithStringConversion()
{
$rootNode = new TreeNode('Root');

$rootNode->addChild('Child 1');
$rootNode->addChild('Child 2');
$rootNode->addChild('Child 3');

$output = new BufferedOutput();
$tree = TreeHelper::createTree($output, $rootNode);

$tree->render();
$this->assertSame(<<<TREE
Root
├── Child 1
├── Child 2
└── Child 3
TREE, self::normalizeLineBreaks(trim($output->fetch())));
}

public function testRenderTreeWithDuplicateNodeNames()
{
$rootNode = new TreeNode('Root');
Expand Down
18 changes: 18 additions & 0 deletions src/Symfony/Component/Console/Tests/Helper/TreeNodeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,24 @@ public function testAddingChildren()
$this->assertSame($child, iterator_to_array($root->getChildren())[0]);
}

public function testAddingChildrenAsString()
{
$root = new TreeNode('Root');

$root->addChild('Child 1');
$root->addChild('Child 2');

$this->assertSame(2, iterator_count($root->getChildren()));

$children = iterator_to_array($root->getChildren());

$this->assertSame(0, iterator_count($children[0]->getChildren()));
$this->assertSame(0, iterator_count($children[1]->getChildren()));

$this->assertSame('Child 1', $children[0]->getValue());
$this->assertSame('Child 2', $children[1]->getValue());
}

public function testAddingChildrenWithGenerators()
{
$root = new TreeNode('Root');
Expand Down
Loading