-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[Process] Enhance hasSystemCallBeenInterrupted function for non-english locale #61401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Removed the labels, no problem 😉 |
0659f8b
to
013126d
Compare
Thank you @christianseel. |
We've been facing an issue with PHPMailer (PHPMailer/PHPMailer#3183) where
stream_select()
returns false, but because our application usessetlocale(LC_ALL, 'de_DE.UTF-8')
, the PHP warning does NOT contain the string'interrupted system call'
which results in unexpected behavior (no retry happening).We did found a fix for this: PHPMailer/PHPMailer#3193
As I known Symfony was using a similar approach, I'm recommending to apply this enhancement to the "interrupted check" as well.