[JsonStreamer] Rebuild cache on class update#62063
Conversation
|
Thanks for looking into this! Unfortunately this didn’t solve the issue, maybe because the target object is not necessarily a resource? |
b5fee7c to
32fc3c6
Compare
|
Indeed, I registered objects as |
|
But to work, the object needs, of course, to be marked with |
|
The documentation says it’s optional? I’m still not seeing any difference though. |
|
see my comment on the issue. Making the cache warmer required and invalidating the whole container cache when the streamable class gets edited is overkill IMO. |
32fc3c6 to
6a4470c
Compare
|
@stof, the PR has been updated to leverage config cache factories (like in translator and router). Let me know if it's the right approach (I'm not used to that). |
|
This is better but it seems the cache won’t be refreshed if a nested class changes. |
eee479e to
348d4e5
Compare
348d4e5 to
84c17a5
Compare
|
Low deps tests should be fixed once merged. |
let me doubt about this: merging up won't change anything to lowest deps |
|
My thought was:
Thinking to this again, I'm indeed wrong, because
WDYT? |
63a9a14 to
05628a9
Compare
05628a9 to
e8c5a10
Compare
e8c5a10 to
cd32dac
Compare
|
Thank you @mtarld. |
This PR was merged into the 7.4 branch. Discussion ---------- [JsonStreamer] Finish #62063 upmerge | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | F | License | MIT Finish the ongoing #62063 upmerge to 7.4. /cc `@nicolas`-grekas Commits ------- c22d2d8 [JsonStreamer] Finish #62063 upmerge
* 7.4: fix merge [HttpFoundation] Fix tests [JsonStreamer] Finish #62063 upmerge [Console] Fix signal handlers not being cleared after command termination [HttpFoundation] Fix RequestTest insulation ReflectionMethod::setAccessible() is no-op since PHP 8.1 CS fix fix merge
…rekas) This PR was merged into the 7.3 branch. Discussion ---------- [FrameworkBundle] Fix wiring JsonStreamReader | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Providing FC/BC to #62063 Commits ------- 215caa3 [FrameworkBundle] Fix wiring JsonStreamReader
Having outdated stream PHP files can lead to unexpected results.
Therefore, this PR leverages the use of
ConfigCacheto regenerate streamers on resource (ie: class) change.