From symfony/finder#2

The usage of fpassthru was introduced in #4751... but the reason is not really clear to me anymore. ping @gajdaw, @stealth35

The reason for fpassthru() was to use internal exceptions handling provided by SplFileObject.

I didn't compare fpassthru() to file_get_contents(). I assumed that they both work in the same way.

If file_get_contents() is better, then I think the best solution is to revert changes introduced in PR:

https://github.com/symfony/symfony/pull/4751/files

An other problem appears.

If I open a big file (e.g 500M) with a memory_limit of 300M, the process shutdown without any error and any other information...

    public function getContents()
    {
        $level = error_reporting(0);
        $content = file_get_contents($this->getRealpath());
        error_reporting($level);
        if (false === $content) {
            $error = error_get_last();
            throw new \RuntimeException($error['message']);
        }

        return $content;
    }

The normal process of the getContents function is to throw a RuntimeException when there is a problem on file_get_contents.. Which is not the case when a Fatal Error occurs...

Maybe we could add a register through : register_shutdown_function and check the error_get_last function.. But there is no unregister_shutdown_function .. Any idea ?

I'm running a CLI script with PHP 5.3.17.

@armetiz catching the fatal error in a register_shutdown_function will not allow you to handle the error inside this function as the shutdown is too late. Other part of your app may have been destructed already.
And if it is only about providing a better error page for developers, this is done in 2.2

@stof, yes you right about the register_shutdown_function

Like I said, I'm using a short script via CLI. I'm using the Finder as a standalone component.

ini_set('memory_limit', '100M');

use Symfony\Component\Finder\Finder;

$finder = new Finder();
$finder->files()
        ->in(__DIR__ . "/../")
        ->name("access_log*");

echo "begin\n";

foreach ($finder as $file) {
        $contents = $file->getContents();

        echo count($contents) . "\n";

        unset($contents);
}

echo "end\n";

If I'm running this script with some files sized up to 200M, the process will display "begin" and that's all.. No error.

IMHO, what I want to say is that disable error reporting, when there is no error manager is not a good thing. If I remove from my example the three "echo", I can think that it's working like a charm, and it's not.

Regards,
Armetiz.

You could handle OOM case yourself, by not opening files larger than memory_limit - memory_get_usage()

@mvrhov of course I can. I'm using a script which is working very well, there is no problem for me.

My last comment is just to improve the Finder component.. Because One day, someone will use the Finder with a file bigger than the memory_limit and there will have no error message.

Thomas.