@nicolas-grekas nice catch. I've removed unset call in the reset method.

In our current project we do a lot of http requests. And there are too many of them has slow ssl handshake (up to 100ms). By introducton of this change we can reduce latency a lot.

There is a good video from @beberlei about that
https://www.youtube.com/watch?v=wr_Jnrc2has

I'm sure it can help reduce latency. I'm just wondering if it could bring some instabilities or unwanted state sharing.

/cc @jwage it'd be great if you could check this one to see how this behaves with your load!

I'm sure it can help reduce latency. I'm just wondering if it could bring some instabilities or unwanted state sharing.

/cc @jwage it'd be great if you could check this one to see how this behaves with your load!

Ohh I was just thinking about this exact thing this morning. So this allows us to share connections between php-fpm requests?

I'm still on 8.3 and we are upgrading to 8.4 but as soon as we get to 8.5 I will test this. I was considering proxying all http-client traffic through a sidecar proxy like envoy to get persistent connections but this would be much simpler!

Is it possible to make it opt in somehow so that we can introduce it safely and then if we have no issues, later we can change it to be enabled by default?

@nicolas-grekas @jwage I've added configuration option (disabled by default) to enable new behavior. Please check

So when I enable "allow", is it used or does cURL decides when to use them? Otherwise the term "allow" is misleading

@nicolas-grekas we have false-positive violations from php-cs-fixer (again). How to deal with that?

I think we might want to change the formatting we use for the documentation of those options.

PHP-CS-Fixer treats line comments that are on their own line as something that should be aligned with the indentation at the place where they are, which is sensible.
The current code formatting is trying to treat multiple line comments as a multiple comment that should be aligned with the first one. This will fight with the automated formatting all the time.

I think we might want to change the formatting we use for the documentation of those options.

done ✔️ . Now all description comments located above array keys and php-cs-fixer is happy.

I've added that as a separate commit, feel free to revert it if you don't like it.

Thank you @Koc.