[Console] Fix choice autocomplete issue when string has spaces#62827
Merged
nicolas-grekas merged 1 commit intoDec 22, 2025
Merged
Conversation
Member
|
I've checked, and the issue is also present in version 6.4. Bug fixes should target the lowest maintained version that has the issue. Also, could you please cover this case with a test? |
5fc68a7 to
c0ce860
Compare
c0ce860 to
db30330
Compare
Contributor
Author
Done! also, can you please add a bug label ? thank you |
db30330 to
fdb3375
Compare
Member
|
Thank you @ayyoub-afwallah. |
This was referenced Dec 31, 2025
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choice = "a test"
Typing "a ", pressing SPACE suggests "a
test" (extra space), then TAB to autocomplete results in "a test" (the extra space is included).The autocomplete logic was trimming the entered value before calculating what to append, ignoring the space the user already typed.
Fix: use the actual entered value length (including spaces).
Also extracted variables for better readability.