[PropertyAccess][PropertyInfo][Serializer] Skip methods that look like getters but return void or never#62886
Merged
Merged
Conversation
d8a35a0 to
7f02051
Compare
7f02051 to
77e51d9
Compare
nicolas-grekas
approved these changes
Dec 29, 2025
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
I applied the same fix where needed.
77e51d9 to
534295b
Compare
534295b to
2256a3f
Compare
…e getters but return void or never
2256a3f to
d2bcf92
Compare
Member
|
Thank you @jordikroon. |
xabbuh
added a commit
that referenced
this pull request
Jan 4, 2026
…tch version (xabbuh) This PR was merged into the 6.4 branch. Discussion ---------- [PropertyAccess] bump required PropertyInfo component patch version | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT fixes low deps tests following the changes made in #62886 Commits ------- ec217ef bump required PropertyInfo component patch version
This was referenced Jan 24, 2026
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fall back to property when potential getter is not readable. For example when it acts as a setter with the same name.
Please beware that fluent methods (those who return $this) and methods that do not have any return type are not excluded from this check.