[Serializer] TranslatableNormalizer before BackedEnumNormalizer#63040
Closed
Seb33300 wants to merge 1 commit into
Closed
[Serializer] TranslatableNormalizer before BackedEnumNormalizer#63040Seb33300 wants to merge 1 commit into
Seb33300 wants to merge 1 commit into
Conversation
dd09b26 to
079697e
Compare
Member
Member
|
We cannot change that now. This is a BC break as projects that have backed enums in their response could suddenly get a different response. Some projects will expect the API to use the machine-readable representation of the So this gets a -1 vote from me. You can still use a custom normalizer for your own enum if you want it to be serialized in a custom way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting
TranslatableNormalizerto be called beforeBackedEnumNormalizer+ add the ability to setNORMALIZATION_LOCALE_KEYtofalsein order to disable translation on purpose (and fallback onBackedEnumNormalizer).