[Serializer] Fix NameConverter not detecting wrong input format with allow_extra_attributes=false#63052
Merged
nicolas-grekas merged 1 commit intoJan 19, 2026
Conversation
2e56af3 to
ddf7926
Compare
…allow_extra_attributes=false
ddf7926 to
55b5388
Compare
nicolas-grekas
approved these changes
Jan 12, 2026
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
👍 I rebased the PR to target 6.4 and made some minor cleanups.
05463f3 to
43b9b18
Compare
Member
|
Nah sorry please revert back to the previous commit I pushed. |
43b9b18 to
55b5388
Compare
Member
I just did it. The fabbot failure should be ignored. |
Contributor
Author
Thanks |
allow_extra_attributes=false
Member
|
Thank you @xersion22. |
This was referenced Jan 24, 2026
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a
NameConverterwithallow_extra_attributes=false, wrongly formatted input (e.g.,someCamelCasePropertyinstead ofsome_camel_case_property) was silently accepted because the unconverted attribute name happened to match the property name.This fix detects when the
NameConverterdidn't transform the input and checks if the property requires a different serialized format. If so, it flags the input as an extra attribute and throwsExtraAttributesException.