[Form] Fix OrderedHashMap auto-increment logic with mixed keys#63144
Merged
nicolas-grekas merged 1 commit intoJan 22, 2026
Conversation
OrderedHashMap auto-increment logic with mixed keys
81ab704 to
10f9f01
Compare
nicolas-grekas
approved these changes
Jan 22, 2026
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
(I fixed another bug in the same code)
Member
|
Thank you @yoeunes. |
Contributor
Author
|
Thank you @nicolas-grekas 🙏🏻 |
This was referenced Jan 24, 2026
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
OrderedHashMaphas mixed integer and string keys, appending a new element overwrites existing integer keys instead of generating a new key: