[DependencyInjection] Fix alias chain inversion when deprecated alias points to decorated service#63160
Merged
nicolas-grekas merged 1 commit intoJan 23, 2026
Conversation
… points to decorated service
Member
|
Good catch, thanks @amateescu. |
This was referenced Jan 24, 2026
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a service is decorated with a private decorator, and there is a deprecated alias pointing to the original service, the compiler passes could invert the alias chain. This caused the original service ID to become an alias pointing to the deprecated interface, triggering false deprecation warnings.
Two issues fixed:
ResolveReferencesToAliasesPasswas not preserving the deprecation flag when resolving alias chainsReplaceAliasByActualDefinitionPassused non-deterministic iteration order, allowing deprecated aliases to "win" when renaming definitionsExample scenario:
Before fix:
$container->get('my_service')would trigger deprecation warningAfter fix: Only
$container->get('App\MyServiceInterface')triggers deprecation warning