[Serializer] Normalize static methods when they have groups#63279
Merged
nicolas-grekas merged 1 commit intoFeb 5, 2026
Conversation
2705c36 to
78c509c
Compare
nicolas-grekas
approved these changes
Feb 5, 2026
Member
|
Thank you @digilist. |
This was referenced Feb 26, 2026
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #63136 introduced a regression that stopped normalization of static methods when they had explicit groups defined. Before that changes, static methods with groups were normalized. Afterwards, these static methods are not normalized anymore.
The regression was caused because previously
ObjectNormalizer::extractAttributes()ignored static methods whileAttributeLoader::loadClassMetadata()did not, and the PR introduced a newgetAttributeNameFromAccessor()method that is shared across those two methods. As a result theAttributeLoader::loadClassMetadata()method is now also ignoring static methods.You can verify this regression by adding the test case from this PR to a commit before the PR was merged (e.g.
1db906a6802c54f8a28f79fbb928d5cb1d5a642c^)