Config key normalization #6367
Merged
Config key normalization #6367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
fabpot
added a commit
that referenced
this pull request
Dec 16, 2012
This PR was merged into the master branch. Commits ------- 6efae29 [TwigBundle] fixed configuration to avoid key normalizations for paths and globals (closes #5998) e31d4f1 [Config] allowed the disabling of key normalization on some array nodes Discussion ---------- Config key normalization This is a quick proof-of-concept for a better fix of #6086, where key normalizations can be disabled on specific nodes. The previous patch was not really useful as you were only able to disable key normalization globally for a configuration. ping @lolautruche The second commit fixes #5998. --------------------------------------------------------------------------- by lolautruche at 2012-12-15T15:39:00Z +1 The approach is neat and much better than my workaround. Gives better control and avoids magic :smiley: (even if this *normalization* is still a bit obscure to me).
| * | ||
| * @return ArrayNodeDefinition | ||
| */ | ||
| public function keepKeys() |
There was a problem hiding this comment.
IMO an other unfortunate name what aboutnormalizeKeys($enabled = true) ?
There was a problem hiding this comment.
You are right. Your suggestion is much better. I've just rename it. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick proof-of-concept for a better fix of #6086, where key normalizations can be disabled on specific nodes. The previous patch was not really useful as you were only able to disable key normalization globally for a configuration.
ping @lolautruche
The second commit fixes #5998.