[HttpKernel] CLI - don't always display errors #6370
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But your patch does not just disable display_errors when logging to stderr AFAIU. |
|
EDIT : yes it does, I've took a look at it again, it is explicitly set to false a few lines above, and this re-enables it only when not logging to stderr (and cli). |
fabpot
added a commit
that referenced
this pull request
Mar 18, 2013
This PR was merged into the master branch. Commits ------- ed58e36 [HttpKernel] CLI - don't always display errors Discussion ---------- [HttpKernel] CLI - don't always display errors I had closed #6370 by mistake when cleaning up my branches. --------------------------------------------------------------------------- by sstok at 2013-02-13T15:13:16Z :+1:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the cli sapi, imo
display_errorsshouldn't be hardcoded to true if errors are logged to stderr, as it would likely display duplicate error messages if the user doesn't redirect stderr when running the command (which should be a common case).