[Security] Add per-username login rate-limit to prevent brute-force attacks#64104
Merged
nicolas-grekas merged 1 commit intoMay 4, 2026
Conversation
Contributor
Author
|
Test failures seem unrelated to this pr |
b4a3196 to
a84ec30
Compare
Member
|
Thank you @ayyoub-afwallah. |
nicolas-grekas
added a commit
that referenced
this pull request
May 4, 2026
…o prevent brute-force attacks" (wouterj) This PR was merged into the 8.1 branch. Discussion ---------- [Security] Revert "Add per-username login rate-limit to prevent brute-force attacks" | Q | A | ------------- | --- | Branch? | 8.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Reverts #64104 | License | MIT Read #61932 (comment) for the reasoning. Commits ------- ef7291c Revert "feature #64104 [Security] Add per-username login rate-limit to prevent brute-force attacks (ayyoub-afwallah)"
Member
|
Hi! Unfortunately, we've discovered that implementing this feature can result in denial of service. A botnet can keep trying a specific username with different IPs, resulting in a user not being able to log in anymore. As a result, we have to revert this feature from the upcoming 8.1 release (ref #64118). I hope this won't discourage you from coming back with more contributions in the future. The contribution itself went very smooth 🚀 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a third rate-limiter to DefaultLoginRateLimiter as suggested in #63997 (comment)