[ObjectMapper] Add MappingAwareTransformCallableInterface#64220
Open
ousamabenyounes wants to merge 1 commit into
Open
[ObjectMapper] Add MappingAwareTransformCallableInterface#64220ousamabenyounes wants to merge 1 commit into
ousamabenyounes wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
MappingAwareTransformCallableInterface, an optional interface a transformer can implement to receive theMapmetadata describing the property currently being mapped (target/source name, condition, transform).Mirrors the existing
ObjectMapperAwareInterfacepattern. Pure addition — existing transformers and existing usage are unaffected.In
ObjectMapper::applyTransforms(), the transformer is enriched if it implements the interface, just likeObjectMapperAwareInterface:Type-hinted as
Map(the public attribute) rather than the internalMetadata\Mappingsubclass so the contract stays inside the public API surface. Public fields (target,source,if,transform) are sufficient for the documented use cases.RED/GREEN verification
Without the fix (
ObjectMapper::applyTransforms()reverted to base onupstream/8.1):With the fix (
MappingAwareTransformCallableInterfacehook restored):The new
testMappingAwareTransformCallablereturns$mapping->targetfrom the transformer; without the hookwithMapping()is never called and the test sees the raw source value'value'instead of'bar'.