Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Tui] Fix description of the bug in BorderPattern#64223

Open
sblondeau wants to merge 2 commits into
symfony:8.1from
sblondeau:fix/border-pattern
Open

[Tui] Fix description of the bug in BorderPattern#64223
sblondeau wants to merge 2 commits into
symfony:8.1from
sblondeau:fix/border-pattern

Conversation

@sblondeau
Copy link
Copy Markdown

@sblondeau sblondeau commented May 15, 2026

Q A
Branch? 8.1
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

fix BorderPattern issue for WIDE, WIDE_MEDIUM, TALL, TALL_MEDIUM
Before fix, white border appears :
image

After fix:
image

@carsonbot carsonbot added this to the 8.1 milestone May 15, 2026
@carsonbot carsonbot changed the title [TUI] Fix description of the bug in BorderPattern [Tui] Fix description of the bug in BorderPattern May 15, 2026
@carsonbot
Copy link
Copy Markdown

carsonbot commented May 15, 2026

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 8.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

GromNaN
GromNaN reviewed May 15, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the screenshots, that really helps to understand the bug and the fix. Would it be possible to add a test in BorderPatternTest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GromNaN GromNaN GromNaN left review comments

Assignees

No one assigned

Labels

Bug Status: Needs Review Tui

Projects

None yet

Milestone

8.1

Development

Successfully merging this pull request may close these issues.

3 participants

@sblondeau @carsonbot @GromNaN