[ObjectMapper] Fix TargetClass generic type in ConditionCallableInterface#64358
Merged
nicolas-grekas merged 1 commit intoMay 28, 2026
Merged
Conversation
3337d11 to
bfc8ee3
Compare
Member
|
For 7.4, isn't it? |
bfc8ee3 to
3b418dd
Compare
Contributor
Author
|
@nicolas-grekas Yes, 7.4 it is |
Member
|
Thank you @mudassaralichouhan. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TargetClassdeclared@implements ConditionCallableInterface<object, T>, which narrows the target generic to theclassNametype. However,__invokeaccepts any?objectat runtime (it only checksinstanceofinternally), so this generic binding was over-specified.The mismatch caused a PHPStan error when using
TargetClassas theifcondition of#[Map]:PHPStan inferred the callable as
callable(mixed, object, ?Foo): bool, which is not contravariantly compatible with thecallable(mixed, object, ?object): booltype expected byMap::$if.Fixing the
@implementsbinding to<object, object>aligns the generic annotation with the actual runtime behavior, with no BC break —@template T of objectis preserved so$classNamekeeps itsclass-string<T>constraint.