Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[2.3] [ClassLoader] Cosmetic change to remove extra spaces in bootstrap file #6753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

yosmanyga
Copy link
Contributor

Bug fix: no
Feature addition: no
Backwards compatibility break: no
Fixes the following tickets: 6752
License of the code: MIT

This patch removes spaces (from T_WHITESPACE token) before a comment (T_COMMENT token).

@vicb
Copy link
Contributor

vicb commented Jan 15, 2013

#6258 probably is a superset of this change (which should probably not be described as a "bug fix")

@yosmanyga
Copy link
Contributor Author

@vicb this patch is just to make the cache file a little more readable, not to optimize it.

Of course, if @fabpot decides to merge your optimizations this patch doesn't make sense.

@vicb
Copy link
Contributor

vicb commented Jan 15, 2013

New features (as opposed to bug fixes) should not target 2.0.

Yosmany Garcia [email protected] wrote:

@vicb this patch is just to make the cache file a little more readable,
not to optimize it.

Of course, if @fabpot decides to merge your optimizations this patch
doesn't make sense.


Reply to this email directly or view it on GitHub:
#6753 (comment)

@fabpot
Copy link
Member

fabpot commented Mar 6, 2013

Closing this PR as #6259 has been merged.

@fabpot fabpot closed this Mar 6, 2013
@yosmanyga yosmanyga deleted the ticket_6752 branch March 7, 2013 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants