[HttpKernel] HttpRenderer fix + enhancements #6801
Conversation
| * | ||
| * @author Fabien Potencier <[email protected]> | ||
| */ | ||
| interface HttpContentRendererInterface |
There was a problem hiding this comment.
to implement without extending, what do you think ?
There was a problem hiding this comment.
I did not create this interface because I don't see why you would want to have another implementation. And you don't need an interface for extending anyway.
There was a problem hiding this comment.
I did not create this interface because I don't see why you would want to have another implementation.
Why not ? (Sorry I can not think of any better reply)
And you don't need an interface for extending anyway.
If you implement this is an other way, you would probably not be interested to extend ?
But I can revert if you prefer (both ?)
|
Just for the sake of the argument, there is no BC break as these classes were not released yet in any stable releases. |
| * | ||
| * @return array | ||
| * | ||
| * @deprecated fixOptions will be removed in 2.3 |
There was a problem hiding this comment.
Then should it really be part of the interface ?
There was a problem hiding this comment.
Good question. I think it is used by external classes (it's public)
|
You are right, UTs are often helpful ! I'll add one for the check. |
|
Well in fact I don't know how/if I can test this ! |
|
I've cherry-picked the second commit |
* 2.2: fixed regression in the Finder component (it was possible to use it without using exec before, closes #6357) fixed a circular call (closes #6864) typo [Security] [Tests] added unit tests for the UserPasswordValidator class and made the validator service for the UserPassword constraint configurable. fixed wrong indentation tweaked previous commit [HttpKernel] Fix the URI signer (closes #6801) Add Arabic translations. [HttpKernel] fixed regression when rendering an inline controller and passing some objects (closes #6822) [FrameworkBundle] fixed typo renamed some classes and Twig functions to more descriptive names (refs #6871) Classcollectionloader: fix traits + enhancements Fix a deprecated method call in the tests Update `composer.json` files: - to allow versions ~2.2 (>=2.2,<3.0) of Doctrine DBAL, ORM & Common - fixed Propel1 versions difference between main and bridge files - fixed Twig versions difference between main and bridge files - to allow versions ~1.11 (>=1.11,<2.0) of Twig - fixed Locale ext-intl version to accept all, not non-existing version Correct comment in NativeSessionStorage regarding session.save_handler [Security] Add PHPDoc to AuthenticationEvents
private->protected)