[HttpFoundation] tweak the Request #6841
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I already tweaked those methods (mainly to fix #6634) and also compared them with the changes done in the upstream ZF (where also some fixes happened). I just didn't make a PR yet because it's not finished. |
|
@Tobion Do you mean I should close this PR ? |
|
Let's wait for my PR. Then we can compare. |
|
If you plan to submit the PR soon, feel free to close this one (and make sure the tweaks are covered by your PR). |
|
Closing as this is not possible anymore because of #6966 |
|
@fabpot, worth rebasing on master ? |
|
I don't think so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit: I find the new version more readable (and it should be marginally faster).
Other commits are a refresh of the CS.