[2.3] [DI] Improve the generated PHPDoc of the dumped PHP container #6846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } elseif ($class = $definition->getClass()) { | ||
| $return = sprintf("@return %s A %s instance.", 0 === strpos($class, '%') ? 'Object' : $class, $class); | ||
| $return[] = sprintf("@return %s A %s instance.", 0 === strpos($class, '%') ? 'Object' : $class, $class); |
There was a problem hiding this comment.
you should improve it here too. Native types should be lowercase, so it should be object
|
@vicb he has an exception for |
| } elseif ($definition->getFactoryService()) { | ||
| $return = sprintf('@return Object An instance returned by %s::%s().', $definition->getFactoryService(), $definition->getFactoryMethod()); | ||
| $return[] = sprintf('@return Object An instance returned by %s::%s().', $definition->getFactoryService(), $definition->getFactoryMethod()); |
There was a problem hiding this comment.
Actually, the @return object also applies for these
By adding "@throws InactiveScopeException" where applicable
|
@stof all "Object"s should be covered now. Yeah I know he has such a mannerism ! |
|
@vicb none of the dumping tests modified ? this looks weird |
|
hmm, travis is indeed agreeing with me... |
|
I'll fix that tomorrow |
|
travis I hope you like it ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding "@throws InactiveScopeException" where applicable