[Finder] fixed regression in the Finder component (it was possible to use it without using exec before, closes #6357) #6882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Jan 25, 2013
| Q | A |
|---|---|
| Bug fix? | yes (fixed a BC break) |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #6357 |
| License | MIT |
| Doc PR | n/a |
… use it without using exec before, closes symfony#6357)
| @@ -52,7 +52,11 @@ public function testCommand($command) | |||
| { | |||
| if (self::TYPE_WINDOWS === $this->type) { | |||
| // todo: find a way to test if windows command exists | |||
| return true; | |||
| return false; | |||
There was a problem hiding this comment.
@fabpot why has this been changed ?
There was a problem hiding this comment.
@fabpot @vicb I dont think it's important,
return truemeans each tested command is available on windows plateformes,return falsemeans no tested command is available on windows plateformes.
Considering that Windows plateformes support is not implemented and that none of the two solutions would be acceptable, I guess the only important thing is to return a boolean, whatever its value.
That said, false may be safer than true.
fabpot
added a commit
that referenced
this pull request
Feb 4, 2013
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #6882). Commits ------- b8ef96e [Finder] fixed regression in the Finder component (it was possible to use it without using exec before, closes #6357) Discussion ---------- [Finder] fixed regression in the Finder component (it was possible to use it without using exec before, closes #6357) | Q | A | ------------- | --- | Bug fix? | yes (fixed a BC break) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6357 | License | MIT | Doc PR | n/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.