[PropertyAccess] Removed underscores from test method names #6885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sistent with other components. It is more common to use fully camel-cased names for test methods. Only some of the test methods are called with underscore notation. To avoid confusion it is better to be consistent.
fabpot
added a commit
that referenced
this pull request
Feb 4, 2013
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #6885). Commits ------- c5d15f8 [PropertyAccess] Removed underscores from test method names to be consistent with other components. Discussion ---------- [PropertyAccess] Removed underscores from test method names Removed underscores from test method names to be consistent with other components. This was previously done in #6695, but was partly lost when merging with master (PropertyAccess component was created, so the location of tests has changed). | Q | A | |--------------|--------------------------------| | Bug fix? | no | |New feature? | no | |BC breaks? | no | |Deprecations? | no | |Tests pass? | yes | |Fixed tickets | n/a | |License | MIT | |Doc PR | n/a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed underscores from test method names to be consistent with other components.
This was previously done in #6695, but was partly lost when merging with master (PropertyAccess component was created, so the location of tests has changed).