[Validator] Fix a deprecated method call in the tests #6938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should go to |
|
Well there has been no official announcement for the 2.2 branch I think ? /cc @fabpot |
|
C'mon Travis, aren't you allowed to fail for 5.5 ? |
|
@vicb error != failed ;-) Yet I agree, that now it's more confusing than before this new status... |
|
I will merged it into 2.2. 2.2 is entering the RC phase, so no more modifications will be merged. |
fabpot
added a commit
that referenced
this pull request
Feb 1, 2013
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #6938). Commits ------- b279dcb [Validator] Fix a deprecated method call in the tests Discussion ---------- [Validator] Fix a deprecated method call in the tests BUG FIX - Travis happier ? --------------------------------------------------------------------------- by stloyd at 2013-02-01T12:23:18Z This should go to `2.2` I guess... =) --------------------------------------------------------------------------- by vicb at 2013-02-01T12:25:43Z Well there has been no official announcement for the 2.2 branch I think ? I hope that some PR pending for master will go into 2.2 anyway ? /cc @fabpot --------------------------------------------------------------------------- by vicb at 2013-02-01T12:38:35Z C'mon Travis, aren't you allowed to fail for 5.5 ? --------------------------------------------------------------------------- by stloyd at 2013-02-01T12:43:42Z @vicb error != failed ;-) Yet I agree, that now it's more confusing than before this new status... --------------------------------------------------------------------------- by fabpot at 2013-02-01T13:27:11Z I will merged it into 2.2. 2.2 is entering the RC phase, so no more modifications will be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG FIX - Travis happier ?