[HttpKernel] fixed regression when rendering an inline controller and passing some objects (closes #6822) #6942
Conversation
fabpot
commented
Feb 1, 2013
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #6822 |
| License | MIT |
| Doc PR | n/a |
… passing some objects (closes symfony#6822)
| { | ||
| $object = new \stdClass(); | ||
|
|
||
| $subRequest = Request::create('/_fragment?_path=_format%3Dhtml%26_controller%3Dmain_controller'); |
There was a problem hiding this comment.
Why are = and & encoded? This should not be the case. In encoded form it means something complete different.
So in this case it must not even work. If it doesnt matter whether they are encoded or not, then it's a bug.
There was a problem hiding this comment.
They are encoded because the whole thing is the value for the _path parameter. If you use = and & instead, it would not work.
There was a problem hiding this comment.
Ok, but why is it called _path then? It does not look like a path to me.
There was a problem hiding this comment.
because the items are the key/value pairs you would have used for the placeholder in the path if you would have created a dedicated route.
There was a problem hiding this comment.
So it should be called something like _params. Because there are placeholders also in the host.
This PR was merged into the 2.2 branch. Commits ------- 8f8d6cf [HttpKernel] fixed regression when rendering an inline controller and passing some objects (closes #6822) Discussion ---------- [HttpKernel] fixed regression when rendering an inline controller and passing some objects (closes #6822) | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6822 | License | MIT | Doc PR | n/a