[Security] Return 401 when using use_forward for form authentication #6957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,7 +53,12 @@ public function start(Request $request, AuthenticationException $authException = | |||
| if ($this->useForward) { | |||
| $subRequest = $this->httpUtils->createRequest($request, $this->loginPath); | |||
|
|
|||
| return $this->httpKernel->handle($subRequest, HttpKernelInterface::SUB_REQUEST); | |||
| $response = $this->httpKernel->handle($subRequest, HttpKernelInterface::SUB_REQUEST); | |||
| if ($response->getStatusCode() == 200) { | |||
There was a problem hiding this comment.
if (200 === $response->getStatusCode()) {
|
You're right, the response status code change is a BC break. |
7 tasks
|
Can you update the CHANGELOG before I merge this PR? Thanks. |
|
@fabpot Done. |
fabpot
added a commit
that referenced
this pull request
Mar 23, 2013
This PR was merged into the master branch. Discussion ---------- [Security] Return 401 when using use_forward for form authentication | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - - [x] document the BC breaks in UPDATE and CHANGELOG Currently, unauthenticated requests gets handled as exceptions and forwarded to the FormAuthenticationEntryPoint::start. When using use_forward = true, this method does not modify the status code, which means that final response to the end user will use a 500 status code. This is not right, as there is not a server problem, the problem is that the user is not authenticated. The status code should be 401. This PR checks if the sub request to the form view is successful, and sets an X-Status-Code header if it is.This might break applications that rely on the 500 error code being returned for unauthenticated requests. Commits ------- b5597e8 [Security] Return 401 when using use_forward for form authentication
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, unauthenticated requests gets handled as exceptions and forwarded to the FormAuthenticationEntryPoint::start. When using use_forward = true, this method does not modify the status code, which means that final response to the end user will use a 500 status code. This is not right, as there is not a server problem, the problem is that the user is not authenticated. The status code should be 401.
This PR checks if the sub request to the form view is successful, and sets an X-Status-Code header if it is.This might break applications that rely on the 500 error code being returned for unauthenticated requests.