[Console] Cleaned up the unit tests. #6989
Conversation
|
|
||
| /** | ||
| * @expectedException \InvalidArgumentException | ||
| * @expectedExceptionMessage The command "foofoo" does not exist. |
There was a problem hiding this comment.
Isn't it nicer to line these comments out, as we do with other PHPdoc annotations?
/**
* @expectedException \InvalidArgumentException
* @expectedExceptionMessage The command "foofoo" does not exist.
*/
|
I'm against these changes because it's going to make merging between tests so much complicated. |
|
@fabpot that's true, I was actually thinking of this as well. However, many of those tests are hard to follow. I could put additional effort to back-porting it to the other branches if needed. If that's not the way to go, please close this PR. |
|
I'm not sure this is worth the effort. But if you want, doing that in the 2.1 branch would be, indeed, better (and cross your fingers for the merge into 2.2 ;)). |
|
👍 tests should be considered as part of the documentation. |
|
👍 for the same reasons as @vicb I use tests a lot to discover how to use features that aren't documented yet in the documentation. |
This PR was merged into the master branch. Discussion ---------- [Console] Cleaned up the unit tests. Cleaned up some unit tests in the Console component as suggested in #6935. I didn't fully cleanup the Application tests to not to delay this PR. I might do it later as a separate one. | Q | A | |--------------|--------------------------------| | Bug fix? | no | |New feature? | no | |BC breaks? | no | |Deprecations? | no | |Tests pass? | yes | |Fixed tickets | #6935 | |License | MIT | |Doc PR | n/a | Commits ------- 5ca04b0 [Console] Cleaned up the unit tests.
|
@fabpot I forgot about this PR. Do you want me to submit another one for 2.1/2.2 branches? |
|
@jakzal No, refactoring such as this one really belongs to master only. Thanks. |
Cleaned up some unit tests in the Console component as suggested in #6935. I didn't fully cleanup the Application tests to not to delay this PR. I might do it later as a separate one.