[HttpKernel] exception listener, allow easier overloading of the default behavior #7021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Feb 8, 2013
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #7021). Commits ------- c9c1ce6 [HttpKernel] exception listener, allow easier overloading of the default behavior Discussion ---------- [HttpKernel] exception listener, allow easier overloading of the default behavior Hi Fabien, This commit you wrote about a month ago helped me to overload the 'logException' method: 1a6c9b3 Because the logger property was private I could not access it from the subclass. This PR changes both properties: controller and logger from private to public members. So they can be used from 'logException'.
|
closing as it has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Fabien,
This commit you wrote about a month ago helped me to overload the 'logException' method:
1a6c9b3
Because the logger property was private I could not access it from the subclass. This PR changes both properties: controller and logger from private to protected members. So they can be used from 'logException'.