[HttpCache] removed x-debug-token from response metadata before storing it #7033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the wrong place to deal with that as HttpCache should have no knowledge of this X-Debug-Token header. |
|
Could you give me some pointers? The only other fix I could see is to do a catch here : https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/Debug/TraceableEventDispatcher.php#L391 and open a section witouth naming it, as it's be done later here IIUC (https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/Debug/TraceableEventDispatcher.php#L391). |
|
I didn't say that it will be easy ;) I will have a look later. |
|
great, thx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using HttpCache on dev environment, looking up and finding a response satisfying the master request leads to a bug with the stopwatch component, because it tries to open a section that doesn't exists, the X-Debug-Token is from an older request.