[HttpKernel/HttpCache] Fix "REMOTE_ADDR" for cached subrequests #7092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabpot rejected setting this on the master request, so you should do it on the |
fabpot
added a commit
that referenced
this pull request
Feb 17, 2013
This PR was submitted for the 2.2 branch but it was merged into the 2.1 branch instead (closes #7092). Commits ------- 187645f Fix REMOTE_ADDR for cached subrequests Discussion ---------- [HttpKernel/HttpCache] Fix "REMOTE_ADDR" for cached subrequests | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | none that I know of | Deprecations? | no | Tests pass? | yes | Fixed tickets | 7091 | License | MIT I moved the code that modifies the REMOTE_ADDR variable further up the chain so that cached subrequests also receive the local IP address. Before, only new subrequests received the local IP address and cached ones received the original IP, which made "validateRequest" in FragmentListener fail. Please review. I'm not sure about side-effects of this patch, including possible security issues. Fixes #7091 --------------------------------------------------------------------------- by bamarni at 2013-02-16T11:49:27Z @fabpot rejected setting this on the master request, so you should do it on the ```forward()``` method instead. --------------------------------------------------------------------------- by mweimerskirch at 2013-02-16T12:13:46Z @bamarni @fabpot done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the code that modifies the REMOTE_ADDR variable further up the chain so that cached subrequests also receive the local IP address. Before, only new subrequests received the local IP address and cached ones received the original IP, which made "validateRequest" in FragmentListener fail.
Please review. I'm not sure about side-effects of this patch, including possible security issues.
Fixes #7091