[Config] tweaked dumper to indent multi-line info#7093
Closed
1ed wants to merge 3 commits into
Closed
Conversation
Member
|
could you add a testcase ? |
Contributor
Author
|
This class had no tests at all, so I thought it's not important... I added one but I have not much experience in writing tests. Is it adequate? I realized that the new numeric node type not supperted by the dumper at all. |
Member
|
looks good to me. However, you should edit the PR description: this is a bugfix |
Contributor
Author
|
@stof done. Thanks! |
Member
|
@fabpot this should even go into 2.1 as it is a bugfix |
Contributor
Author
|
@stof there is no ReferenceDumper class in 2.1 |
Member
|
ah, it was directly in the command in 2.1. But the bug should still be fixed IMO |
Member
|
I've merged this PR in 2.2 as the patch for 2.1 will be different. |
fabpot
added a commit
that referenced
this pull request
Feb 17, 2013
This PR was squashed before being merged into the 2.2 branch (closes #7093). Commits ------- 609636e [Config] tweaked dumper to indent multi-line info Discussion ---------- [Config] tweaked dumper to indent multi-line info | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Little cosmetic tweak. before: ```yaml # router configuration router: resource: ~ # Required type: ~ http_port: 80 https_port: 443 # set to true to throw an exception when a parameter does not match the requirements set to false to disable exceptions when a parameter does not match the requirements (and return null instead) set to null to disable parameter checks against requirements 'true' is the preferred configuration in development mode, while 'false' or 'null' might be preferred in production strict_requirements: true # session configuration session: ``` after: ```yaml # router configuration router: resource: ~ # Required type: ~ http_port: 80 https_port: 443 # set to true to throw an exception when a parameter does not match the requirements # set to false to disable exceptions when a parameter does not match the requirements (and return null instead) # set to null to disable parameter checks against requirements # 'true' is the preferred configuration in development mode, while 'false' or 'null' might be preferred in production strict_requirements: true # session configuration ``` --------------------------------------------------------------------------- by stof at 2013-02-17T01:49:27Z could you add a testcase ? --------------------------------------------------------------------------- by 1ed at 2013-02-17T05:15:10Z This class had no tests at all, so I thought it's not important... I added one but I have not much experience in writing tests. Is it adequate? I realized that the new numeric node type not supperted by the dumper at all. --------------------------------------------------------------------------- by stof at 2013-02-17T11:27:43Z looks good to me. However, you should edit the PR description: this is a bugfix --------------------------------------------------------------------------- by 1ed at 2013-02-17T11:32:07Z @stof done. Thanks! --------------------------------------------------------------------------- by stof at 2013-02-17T11:41:44Z @fabpot this should even go into 2.1 as it is a bugfix --------------------------------------------------------------------------- by 1ed at 2013-02-17T11:44:08Z @stof there is no ReferenceDumper class in 2.1 --------------------------------------------------------------------------- by stof at 2013-02-17T12:23:44Z ah, it was directly in the command in 2.1. But the bug should still be fixed IMO
1ed
added a commit
to 1ed/symfony
that referenced
this pull request
Feb 17, 2013
Contributor
Author
fabpot
added a commit
that referenced
this pull request
Feb 17, 2013
* 2.1: [FrameworkBundle] tweaked reference dumper command (see #7093) [HttpKernel] added some tests for previous merge Fix REMOTE_ADDR for cached subrequests [Process] Warn user with a useful message when tmpfile() failed Conflicts: src/Symfony/Bundle/FrameworkBundle/Command/ConfigDumpReferenceCommand.php
fabpot
added a commit
that referenced
this pull request
Feb 18, 2013
* 2.2: (22 commits) [Process] Fix regression introduced in #6620 / 880da01, fixes #7082 [HttpKernel] added a unit for the previous commit (closes #7025) [HttpFoundation] fixed, overwritten CONTENT_TYPE [BrowserKit] fixed test added in the previous merge (refs #7059) [FrameworkBundle] tweaked reference dumper command (see #7093) Remove unnecessary comment and change test name [Config] tweaked dumper to indent multi-line info [HttpKernel] added some tests for previous merge Fix REMOTE_ADDR for cached subrequests [FrameworkBundle] CSRF should be on by default [WebProfilerBundle] removed dependency on FrameworkBundle (closes #6949) [HttpKernel] added error display suppression when using the ErrorHandler (if not, errors are displayed twice, refs #6254) [HttpFoundation] tweaked previous merge [HttpFoundation] Added getter for httpMethodParameterOverride state Create validators.lv.xlf [Process] Warn user with a useful message when tmpfile() failed [BrowserKit] added a test to make sure HTTP authentication is preserved when submitting a form Remove array type hint from GetResponseForControllerResultEvent::setControllerResult() bumped Symfony version to 2.2.0-DEV Revert "merged branch povilas/issue_6101 (PR #6708)" ...
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
* 2.2: (22 commits) [Process] Fix regression introduced in symfony#6620 / 880da01, fixes symfony#7082 [HttpKernel] added a unit for the previous commit (closes symfony#7025) [HttpFoundation] fixed, overwritten CONTENT_TYPE [BrowserKit] fixed test added in the previous merge (refs symfony#7059) [FrameworkBundle] tweaked reference dumper command (see symfony#7093) Remove unnecessary comment and change test name [Config] tweaked dumper to indent multi-line info [HttpKernel] added some tests for previous merge Fix REMOTE_ADDR for cached subrequests [FrameworkBundle] CSRF should be on by default [WebProfilerBundle] removed dependency on FrameworkBundle (closes symfony#6949) [HttpKernel] added error display suppression when using the ErrorHandler (if not, errors are displayed twice, refs symfony#6254) [HttpFoundation] tweaked previous merge [HttpFoundation] Added getter for httpMethodParameterOverride state Create validators.lv.xlf [Process] Warn user with a useful message when tmpfile() failed [BrowserKit] added a test to make sure HTTP authentication is preserved when submitting a form Remove array type hint from GetResponseForControllerResultEvent::setControllerResult() bumped Symfony version to 2.2.0-DEV Revert "merged branch povilas/issue_6101 (PR symfony#6708)" ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Little cosmetic tweak.
before:
after: