[Form] Fixes php fatal error in CsrfValidationListener when form is bound with a string #7136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is temporary as #7007 will fix it properly in Symfony 2.3.
This PR was merged into the 2.1 branch. Commits ------- 3e40c17 [HttpKernel] fixed locale management when exiting sub-requests Discussion ---------- [HttpKernel] fixed locale management when exiting sub-requests | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7063 | License | MIT | Doc PR | n/a This fix is temporary as #7007 will fix it properly in Symfony 2.3. --------------------------------------------------------------------------- by vicb at 2013-02-17T20:17:44Z changelog ? --------------------------------------------------------------------------- by fabpot at 2013-02-17T20:27:22Z The changelogs are updated when we release a new version only. --------------------------------------------------------------------------- by stof at 2013-02-17T20:41:00Z @fabpot the intl locale should be reset to the right value too --------------------------------------------------------------------------- by stof at 2013-02-17T20:42:31Z hmm sorry, I missed the fact that you are changing the locale in the Request again, which will set the intl one
|
It looks like you created your branch based on 2.1 but selected master as target of the PR, and 2.1 has some commits not merged yet into master. Could you recreate the PR but choising the right target so that the diff only includes the relevant commits ? |
|
Should I select symfony/symfony 2.1 as target ? |
|
As your branch has been created from the symfony 2.1 branch, yes |
|
Sorry for the three PRs... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR : #7126
This PR includes a php unit test to reproduce the php fatal error.
$ phpunit src/Symfony/Component/Form/Tests/Extension/Csrf
PHPUnit 3.7.14 by Sebastian Bergmann.
..............PHP Fatal error: Cannot unset string offsets in src/Symfony/Component/Form/Extension/Csrf/EventListener/CsrfValidationListener.php on line 70