[Form] Fixed TimeType not to render a "size" attribute in select tags #7155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
webmozart
commented
Feb 22, 2013
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #6153 |
| License | MIT |
| Doc PR | - |
| @@ -1,17 +1,18 @@ | |||
| <?php if ($widget == 'single_text'): ?> | |||
| <?php echo $view['form']->block($form, 'form_widget_simple'); ?> | |||
| <?php else: ?> | |||
| <?php $vars = $widget == 'text' ? array('attr' => array('size' => 1)) : array() ?> | |||
There was a problem hiding this comment.
I made this consistent with line 1. Feel free to create a PR fixing all templates (including the Twig ones) to use YODA style.
There was a problem hiding this comment.
The Twig CS don't include Yoda condition (the main reason for Yoda condition is to avoid mistakes like $widget = 'text' ? ... and it does not apply to Twig as it would be a syntax error)
There was a problem hiding this comment.
Whatever the reason, usage should be consistent IMO.
fabpot
added a commit
that referenced
this pull request
Feb 22, 2013
This PR was merged into the 2.1 branch. Commits ------- b7bd630 [Form] Fixed TimeType not to render a "size" attribute in select tags Discussion ---------- [Form] Fixed TimeType not to render a "size" attribute in select tags | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6153 | License | MIT | Doc PR | -
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.