Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixing issue #7185 and add some phpDoc #7186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixing issue #7185 and add some phpDoc #7186

wants to merge 1 commit into from

Conversation

Strate
Copy link
Contributor

@Strate Strate commented Feb 26, 2013

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #7185
License MIT

@fabpot
Copy link
Member

fabpot commented Feb 27, 2013

I think that the comment should be fixed instead. The Request class is a data bag holding information about the request, I don't think anyway should need to override it. Moreover, there are more usage of Request::create() in the framework, so "just" fixing one occurrence is obviously wrong.

@Strate
Copy link
Contributor Author

Strate commented Feb 27, 2013

@fabpot , in my application I use only HttpKernel component (not full framework), and I have my own Request class with some useful methods that needed in my application.
If you think that no cases to override Request class it must be declared as final or it must be documented.

@jfsimon jfsimon mentioned this pull request Mar 18, 2013
Merged
fabpot added a commit that referenced this pull request Mar 18, 2013
@fabpot
merged branch jfsimon/issue-7185-2.2 (PR #7390)
d9181ba 
This PR was merged into the 2.2 branch.

Commits
-------

53cf12b replaced new occurences of 'Request::create()' with '::create()'

Discussion
----------

[2.2] sub-requests are now created with the same class as their parent

Following #7381

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #7185, #7186
@fabpot fabpot closed this Mar 18, 2013
@Strate
Copy link
Contributor Author

Strate commented Mar 18, 2013

@fabpot, PR #7390 does not fixes src/Symfony/Component/HttpKernel/Fragment/InlineFragmentRenderer.php file. Why you don`t want to apply my PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Strate @fabpot