[2.2] add http_method_override option to ease setup #7202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
havvg
commented
Feb 27, 2013
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| License | MIT |
| @@ -52,6 +52,7 @@ public function getConfigTreeBuilder() | |||
| ->end() | |||
| ->end() | |||
| ->scalarNode('secret')->end() | |||
| ->scalarNode('http_method_override')->defaultFalse()->end() | |||
| @@ -52,6 +52,10 @@ public function getConfigTreeBuilder() | |||
| ->end() | |||
| ->end() | |||
| ->scalarNode('secret')->end() | |||
| ->scalarNode('http_method_override') | |||
| ->info("Set true to enable support for the '_method' request parameter to determine the intended HTTP method on POST requests.") | |||
| ->defaultFalse() | |||
There was a problem hiding this comment.
I would set it to true by default (as this is what is done in the Symfony Standard Edition).
|
@fabpot IMHO this would be useful in 2.2 as well (without the last commit, leaving the default to false). |
|
I agree but in 2.2, just use Being strict about what goes in which release is more and more important IMO. |
This was referenced Mar 25, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.