[Console] fixes tests #7232
Merged
[Console] fixes tests #7232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Mar 1, 2013
This PR was merged into the 2.2 branch. Commits ------- 5bf2f71 [Console] added deprecation annotation f95f8e2 [Console] added string input test 4b12118 Revert "merged branch jfsimon/issue-6749 (PR #7220)" Discussion ---------- [Console] fixes tests Previous `StringInputTest::testInputOptionWithGivenString` test was broken. Trying make it pass broke the way `StringInput` is used in the console. Two things to know abour the `StringInput` class in its actual state: * the second argument in the constructor is useless * the `bind` method **must** be called in order to access arguments/options | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes
Member
There was a problem hiding this comment.
@jfsimon Wouldn't it be possible to call bind at the end of the constructor so that the argument is working ?
Member
There was a problem hiding this comment.
or maybe to call the parent constructor only after tokenizing ?
Contributor
There was a problem hiding this comment.
And if the argument is deprecated it should be removed from the constructor signature. And you func_get_args instead.
Member
There was a problem hiding this comment.
@Tobion there is a pending PR making it work properly again, so there will be no reason to deprecate it because being broken.
jfsimon
referenced
this pull request
Mar 1, 2013
Member
|
@fabpot The previous PR was merged into 2.1 but you only reverted in 2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous
StringInputTest::testInputOptionWithGivenStringtest was broken.Trying make it pass broke the way
StringInputis used in the console.Two things to know abour the
StringInputclass in its actual state:bindmethod must be called in order to access arguments/options